nxos_snmp_traps: fix 'group: all' for N35 platforms #55995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `group: all` attempts to enable traps for all features defined in the module's `feature_list` - `N35` platforms do not support `snmp-server enable traps bfd`; so removing `bfd` from the `feature_list` for that platform - Minor cleanup in `sanity.yaml` test file
ansibot
added
affects_2.9
ansibot
added
core_review
ansibot
removed
the
needs_triage
trishnaguha
approved these changes
May 7, 2019
trishnaguha
pushed a commit
to trishnaguha/ansible
that referenced
this pull request
May 8, 2019
* nxos_snmp_traps: fix 'group: all' for N35 platforms - `group: all` attempts to enable traps for all features defined in the module's `feature_list` - `N35` platforms do not support `snmp-server enable traps bfd`; so removing `bfd` from the `feature_list` for that platform - Minor cleanup in `sanity.yaml` test file * whitespace lint fix (cherry picked from commit 0e0c2a7)
abadger
pushed a commit
that referenced
this pull request
May 21, 2019
* nxos_snmp_traps: fix 'group: all' for N35 platforms - `group: all` attempts to enable traps for all features defined in the module's `feature_list` - `N35` platforms do not support `snmp-server enable traps bfd`; so removing `bfd` from the `feature_list` for that platform - Minor cleanup in `sanity.yaml` test file * whitespace lint fix (cherry picked from commit 0e0c2a7)
ndclt
pushed a commit
to ndclt/ansible
that referenced
this pull request
Jun 13, 2019
* nxos_snmp_traps: fix 'group: all' for N35 platforms - `group: all` attempts to enable traps for all features defined in the module's `feature_list` - `N35` platforms do not support `snmp-server enable traps bfd`; so removing `bfd` from the `feature_list` for that platform - Minor cleanup in `sanity.yaml` test file * whitespace lint fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
group: allattempts to enable traps for all features defined in the module'sfeature_listN35platforms do not supportsnmp-server enable traps bfd; so removingbfdfrom thefeature_listfor that platformMinor cleanup in
sanity.yamltest fileISSUE TYPE
COMPONENT NAME
modules/network/nxos/nxos_snmp_traps.pyADDITIONAL INFORMATION
Changes validated on:
N3K, N3K-F, N35, N6K, N7K, N9K, N9K-F